Devcontainer: enable coredumps #7523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7523 +/- ##
==========================================
- Coverage 89.61% 89.51% -0.10%
==========================================
Files 282 282
Lines 60375 60373 -2
Branches 7522 7522
==========================================
- Hits 54105 54045 -60
- Misses 4118 4148 +30
- Partials 2152 2180 +28 |
thanodnl
commented
Feb 20, 2024
.devcontainer/devcontainer.json
Outdated
| @@ -1,9 +1,12 @@ | |||
| { | |||
| "image": "ghcr.io/citusdata/citus-devcontainer:main", | |||
| "image": "ghcr.io/citusdata/citus-devcontainer:devcontainer-coredumps", | |||
There was a problem hiding this comment.
TODO: before merging, revert image tag
eaydingol
approved these changes
Feb 20, 2024
JelteF
reviewed
Feb 21, 2024
JelteF
reviewed
Feb 21, 2024
Co-authored-by: Jelte Fennema-Nio <[email protected]>
thanodnl
force-pushed
the
devcontainer/coredumps
branch
from
b6be08e to
6fd5cbe
Compare
emelsimsek
pushed a commit
that referenced
this pull request
Mar 11, 2024
Add configuration for coredumps and document how to make sure they are enabled when developing in a devcontainer. --------- Co-authored-by: Jelte Fennema-Nio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration for coredumps and document how to make sure they are enabled.