Disable nonmaindb interface #7903
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7903 +/- ##
==========================================
- Coverage 89.70% 89.39% -0.31%
==========================================
Files 283 283
Lines 60519 60513 -6
Branches 7544 7541 -3
==========================================
- Hits 54286 54095 -191
- Misses 4079 4243 +164
- Partials 2154 2175 +21 |
| DROP FUNCTION pg_catalog.citus_unmark_object_distributed(oid, oid, int); | ||
| #include "udfs/citus_unmark_object_distributed/12.2-1.sql" | ||
| #include "udfs/commit_management_command_2pc/12.2-1.sql" |
There was a problem hiding this comment.
Should we also delete these files altogether, and not just remove the include line here?
There was a problem hiding this comment.
My goal is to remove only the interface with minimal changes. I kept the files because their C implementations are still present in the codebase.
As you suggested, we can also remove the SQL and test files altogether. This way, we wouldn't need the name change and the additional schedule (from other comments).
There was a problem hiding this comment.
the alternative #7905
There was a problem hiding this comment.
I am leaning towards the alternative, especially for the .sql files. We don't keep .sql files with a Citus version in their name that we don't use.
I still think the changes are minimal if we remove the .sql files and the relevant tests as well. Wondering if codecov would complain though.
| @@ -0,0 +1,4 @@ | |||
| test: failure_non_main_db_2pc | |||
There was a problem hiding this comment.
Is this schedule runnable?
If not, maybe we don't need to introduce this schedule.
There was a problem hiding this comment.
Not actually, it includes the removed tests. "check_all_tests_are_run" complains without it.
|
I guess you have modified the |
DESCRIPTION: PR description that will go into the change log, up to 78 characters