CCIP-020: Graceful Protocol Shutdown #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedger
reviewed
Apr 2, 2024
friedger
reviewed
Apr 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 88.86% 88.89% +0.03%
==========================================
Files 21 22 +1
Lines 1356 1468 +112
Branches 206 231 +25
==========================================
+ Hits 1205 1305 +100
- Misses 137 148 +11
- Partials 14 15 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
whoabuddy
changed the title
This simplifies the contract per CCIP-020 to only address the shutdown of mining/stacking.
There are still a few more tests to add now that we're tracking votes per city, but the ratio in is-executable feels off here. Will post back to Discord for consensus.
Reminder: contract names have a length limit in older versions of Clarinet. It passed check but failed with a readonly() function error in test suite.
The expected balance is hardcoded and changed with a test proposal that required funding from the deployer account.
|
Technical preparations for voting are being finalized, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of citycoins/governance#30
Redemption contracts need to be deployed first.CCIP-020 proposal will disable mining/stacking in the protocol, more info in this comment.