Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-021: Extend Direct Execution Sunset Period #69

Merged
merged 18 commits into from
Apr 6, 2024
Merged

Conversation

friedger
Copy link
Contributor

@friedger friedger commented Apr 4, 2024

@friedger friedger requested a review from whoabuddy April 4, 2024 20:15
Copy link
Contributor

@whoabuddy whoabuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few things but overall looks great, thank you!

contracts/proposals/ccip021-extend-sunset-period-2.clar Outdated Show resolved Hide resolved
contracts/proposals/ccip021-extend-sunset-period-2.clar Outdated Show resolved Hide resolved
contracts/proposals/ccip021-extend-sunset-period-2.clar Outdated Show resolved Hide resolved
contracts/proposals/ccip021-extend-sunset-period-2.clar Outdated Show resolved Hide resolved
contracts/proposals/ccip021-extend-sunset-period-2.clar Outdated Show resolved Hide resolved
contracts/proposals/ccip021-extend-sunset-period-2.clar Outdated Show resolved Hide resolved
@whoabuddy
Copy link
Contributor

Also see the change in #70 to pin the Clarinet version so the tests pass :)

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 96.80851% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.86%. Comparing base (27a0c8f) to head (01b13a2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   88.27%   88.86%   +0.59%     
==========================================
  Files          20       21       +1     
  Lines        1262     1356      +94     
  Branches      188      206      +18     
==========================================
+ Hits         1114     1205      +91     
  Misses        137      137              
- Partials       11       14       +3     
Files Coverage Δ
...acts/proposals/ccip021-extend-sunset-period-2.clar 96.80% <96.80%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a0c8f...01b13a2. Read the comment docs.

@whoabuddy whoabuddy merged commit 379ddaa into main Apr 6, 2024
1 check passed
@whoabuddy whoabuddy deleted the feat/ccip-021 branch April 6, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants