CCIP-024: MiamiCoin Community Signal Vote #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 88.29% 88.25% -0.04%
==========================================
Files 24 25 +1
Lines 1657 1737 +80
Branches 275 294 +19
==========================================
+ Hits 1463 1533 +70
- Misses 174 180 +6
- Partials 20 24 +4
Continue to review full report in Codecov by Sentry.
|
All tests are expecting to use early stacking cycles in order to vote, but the contract sets the voting window too soon when it just goes off the block height it's deployed. For testing we extend the set blocks by u12600 which represents 6 * 2100 block cycle length. This should be removed for mainnet deployment and comments above include the correct code for deployment.
The logic can be simplified here since we have a set end block height for the vote, tests are updated as well.
whoabuddy
force-pushed
the
fix/implement-ccip-024
branch
from
ac0d730 to
14edf5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation for citycoins/governance#44 and citycoins/governance#43