Edit LookupAutocompleteComponent to update related field #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g object thing and also fixes other bugs
… filter, update to use user_ids
chiaberry
commented
Mar 7, 2025
| @@ -73,13 +89,35 @@ const useColumns = ({ | |||
| return user ? `${user.first_name} ${user.last_name}` : ""; | |||
| }, | |||
| renderEditCell: (props) => { | |||
| // the team member object for the current row | |||
There was a problem hiding this comment.
I merged Rose's branch into mine, this is from her PR
chiaberry
changed the title
chiaberry
changed the title
chiaberry
requested review from
mddilley,
frankhereford,
mateoclarke,
johnclary,
tillyw and
roseeichelmann
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issues
cityofaustin/atd-data-tech#21358
This shouldn't be merged until Rose's PR is merged #1551. I pulled her branch into this one since she fixed a bug in the Team Autocomplete. I tried to see if the Milestone table had the same bug, but I couldnt reproduce. I think its because the related field in the milestone table is displaying something from the same object as the moped_milestone.
Testing
URL to test:
https://deploy-preview-1552--atd-moped-main.netlify.app/moped/projects/
Steps to test:
This PR removes the Milestone Autocomplete and the Team Member Autocomplete and replaces them with the LookupAutocomplete from #1540.
Team table
Milestones table (on Timeline tab)
Test another LookupAutocompleteField that doesn't update a dependent, to make sure there are no regressions. Any of the autocompletes on the Funding table are good candidates.
Ship list