Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of waits and retries to have the instance vnc URL ready #489

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

alessandroargentieri
Copy link
Member

VNC Console access URL is not immediately ready and requires some retries.
This PR aims to perform the retries before redirecting the user to the default browser.
Manual test performed:

~/work/cli  $ go run main.go instance vnc 34e0e710-8d72-4e2a-8997-45561a87s510
Info: VNC has been successfully enabled for instance: blossom2
Info: VNC URL: https://vnc.lon1.civo.com/34e0e710-8d72-4e2a-8997-45561a87s510/vnc.html?path=34e0e710-8d72-4e2a-8997-45561a87s510/websockify
Info: We're preparing the VNC Console Access. This may take a while...
Info: New attempt to reach the VNC Console URI...
Info: New attempt to reach the VNC Console URI...
Info: Opening VNC in your default browser...
Info: VNC session is now active. You can access your instance's graphical interface.

@uzaxirr uzaxirr merged commit 7c2865b into master Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants