-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node watcher functionality and test case #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
jokestax
reviewed
Feb 27, 2025
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
jokestax
approved these changes
Feb 27, 2025
Thank you for your review! I will merge this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the implementation of a watcher that periodically checks the status of nodes in a Kubernetes cluster, specifically focusing on the availability of GPUs and the readiness of the nodes.
The watcher works as follows:
it fetches the list of nodes that match the specified selector.
It then checks if the node meets the desired GPU count and whether the node is in a ready state. If either condition is not met, the node is considered unready.
If a node is found to be unready or doesn't have the expected GPU count, the watcher attempts to reboot the node by invoking a reboot on the corresponding instance in Civo.
This functionality ensures that nodes are automatically monitored and rebooted if necessary to meet the specified conditions, maintaining optimal performance and readiness.