Fixed Favourite Parameters in Symfony 3.4 and Ibexa Platform 2.5

PHP: - FavouritesParamCoordinator.php: Enforced overwriting the cached favourites when removing or saving new favourites (again the Symfony cache did not successfully detect that its item had been deleted) - LocationRetrievalCoordinator.php: Removed unnecessary documentation parts
cjw-network · Dec 15, 2020 · d4288bc · d4288bc
1 parent 418d8d6
commit d4288bc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/ConfigProcessorBundle/FavouritesParamCoordinator.php b/src/ConfigProcessorBundle/FavouritesParamCoordinator.php
@@ -118,10 +118,13 @@ function() use ($favouriteRetrievalProcessor, $processedParameters) {
 
             if (count($uncommonFavourites[0]) > 0) {
                 self::$cache->deleteItem("cjw_custom_favourite_parameters");
-                Utility::cacheContractGetOrSet("cjw_custom_favourite_parameters", self::$cache,
+                Utility::cacheContractGetOrSet(
+                    "cjw_custom_favourite_parameters",
+                    self::$cache,
                     function() use ($previousFavourites, $newFavourites) {
                        return array_replace_recursive($previousFavourites, $newFavourites);
-                    }
+                    },
+                    true
                 );
             }
         }
@@ -158,10 +161,13 @@ function() use ($favouriteRetrievalProcessor, $processedParameters) {
         if (count($uncommonFavourites[1]) > 0) {
             self::$cache->deleteItem("cjw_custom_favourite_parameters");
 
-            Utility::cacheContractGetOrSet("cjw_custom_favourite_parameters", self::$cache,
+            Utility::cacheContractGetOrSet(
+                "cjw_custom_favourite_parameters",
+                self::$cache,
                 function () use ($currentFavourites) {
                     return $currentFavourites;
-                }
+                },
+                true
             );
         }
     }

diff --git a/src/LocationAwareConfigLoadBundle/LocationRetrievalCoordinator.php b/src/LocationAwareConfigLoadBundle/LocationRetrievalCoordinator.php
@@ -17,7 +17,7 @@ class LocationRetrievalCoordinator
     /** @var array An array which not only stores the parameters, but also the paths they have been read from (including the values set there) */
     public static $parametersAndLocations;
 
-    /** @var PhpFilesAdapter A cache which is supposed to store the parameters that have been parsed. */
+    /** @var PhpFilesAdapter A cache which is supposed to store parameters that have been parsed. */
     private static $cache;
 
     /** @var bool */