-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docs with Croissant information. #330
base: croissant
Are you sure you want to change the base?
Conversation
Hi @amercader, just moving the conversation from #328 to here. Many thanks for the changes to enable Croissant features as a plugin, and to provide a dedicated endpoint. I synced with these latest changes and tried them out, and all works as expected. I wouldn't have so easily figured out what's needed to enable these new features, so your work is a big help, and of course it then naturally fits in with your desired structure too. I looked at the existing docs, and thought that maybe the Croissant info could better sit in the existing files rather than a new file. Firstly, the schema info naturally sits alongside other schema info in Finally, when producing the new examples just mentioned, I noticed that the Please let me know what you think of the above when you have time. |
Hi @Reikyo thanks for this, see below:
This looks pretty high level so maybe there's something obvious that needs to be tweaked in the profile? This eventually needs to run in an automated test so we make sure the output remains valid in the future. I added the test in 7fd67fe so you can run it locally if you want but it's essentially the same as running the validator, only the test uses a dataset with all properties present. I'm getting errors when providing the
|
After much debugging I found out the issue causing the
|
Hi @amercader - thanks for the continued efforts here, and apologies as I've been busy with another project which has diverted attention lately. Firstly regarding documentation, yes please modify according to your preferred format and breakdown. I hope there's enough info in what I already supplied, just let me know if anything needs further clarification. I'll need to get some further input from others in the Croissant working group to be completely sure of the implementation details to be added to the docs. Secondly I need to spend some time with those tests and validation errors to check through properly. I had a very quick look, and noted that Please bear with me while I look into this, time is also further limited this week due to annual leave, but I'll try and get the needed conversations going at the very least. |
No worries @Reikyo I can completely relate. There's no rush in getting this merged and I'd rather get it right. I'll also spend some time this week to work on docs and look at these errors, so I'm confident we can get it over the line soon. |
No description provided.