Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React v17 #159

Closed
f1ames opened this issue Jan 4, 2021 · 2 comments · Fixed by #199
Closed

Support React v17 #159

f1ames opened this issue Jan 4, 2021 · 2 comments · Fixed by #199
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
2.0.0

Comments

@f1ames
Copy link
Contributor

f1ames commented Jan 4, 2021 •
edited
Loading

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

React 17 is out for some time already and we have already checked if it works with the integration (by updating deps and running all tests). However, one blocker we have is that Enzyme does not support React 17.

We should wait for it to be resolved as there is significant activity there (or if not look for a way around).
@f1ames f1ames added status:confirmed An issue confirmed by the development team. type:feature A feature request. size:? labels Jan 4, 2021
@Dumluregn Dumluregn mentioned this issue Mar 2, 2021
Merged
@f1ames f1ames mentioned this issue Apr 6, 2021
Closed
@MMMalik MMMalik mentioned this issue Apr 7, 2021
Closed
@MMMalik MMMalik added this to the 2.0.0 milestone Apr 16, 2021
@MMMalik MMMalik mentioned this issue Apr 23, 2021
Merged
@MMMalik MMMalik linked a pull request Apr 23, 2021 that will close this issue
Prepare ground for v2 #199
Merged
@psyycker
Copy link

Technically, there is an adapter for Enzyme for Reacy 17. It's working pretty well: @wojtekmaj/enzyme-adapter-react-17

@CKEditorBot
Copy link
Collaborator

Closed in #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Prepare ground for v2 ckeditor/ckeditor4-react
4 participants
@f1ames @psyycker @MMMalik @CKEditorBot