Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device management #399

Merged
merged 12 commits into from
Nov 19, 2024
Merged

Device management #399

merged 12 commits into from
Nov 19, 2024

Conversation

StRigaud
Copy link
Member

@StRigaud StRigaud commented Nov 19, 2024

Attempt to improve backend code for device and ressources management with OpenCL.

Objectives are:

  • improve device switch
  • improve code structure
  • enquiry/solve memory issue when running with dask

Closes clEsperanto/pyclesperanto#283
Closes #387

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 51.90476% with 101 lines in your changes missing coverage. Please review.

Project coverage is 46.65%. Comparing base (5c32a1a) to head (d712c88).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
clic/src/opencldevice.cpp 56.92% 14 Missing and 42 partials ⚠️
clic/src/openclbackend.cpp 44.73% 11 Missing and 31 partials ⚠️
clic/src/array.cpp 25.00% 0 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   46.54%   46.65%   +0.11%     
==========================================
  Files         199      199              
  Lines        3848     3967     +119     
  Branches     1767     1810      +43     
==========================================
+ Hits         1791     1851      +60     
- Misses        692      715      +23     
- Partials     1365     1401      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@StRigaud
Copy link
Member Author

After a local tests, this PR solve the memory issue when using dask with multi-gpu

@StRigaud StRigaud merged commit 5c88807 into master Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants