-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix orthogonal interpolation #284
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haesleinhuepf I think we ran some of the notebooks before we made some kernel changes, especially the flip z for backward compatbility
As far as I can tell, there are no breaking changes downstream..
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 92.95% 92.95% -0.01%
==========================================
Files 772 772
Lines 14300 14304 +4
==========================================
+ Hits 13293 13296 +3
- Misses 1007 1008 +1
☔ View full report in Codecov by Sentry. |
Hi @haesleinhuepf Cheers |
The error for tests is related to
For some reason it fails for python 3.8, 3.9, 3.10 |
@haesleinhuepf , I modified the test to make test_skimage_save test work. Changes here: |
Bug fix for issues:
Waiting for confirmation from @oleksiievetsno before merging.
Cheers
Pradeep