Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data #887

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

Data #887

wants to merge 55 commits into from

Conversation

matyaskopp
Copy link
Collaborator

No description provided.

@matyaskopp matyaskopp removed the request for review from TomazErjavec December 4, 2024 09:55
@TomazErjavec
Copy link
Collaborator

@matyaskopp, what's happening to the checks? Are they stuck or merely take so long?

@matyaskopp
Copy link
Collaborator Author

@TomazErjavec I had to trigger the action again with empty commit, now it seems to work

@TomazErjavec
Copy link
Collaborator

@TomazErjavec I had to trigger the action again with empty commit, now it seems to work

@matyaskopp, indeed, it did finish now, now checks are failing for some countries (e.g. EE, FR). However, I can't see why, maybe you can? It would be good (and expected) if the checks succeeded.

@matyaskopp
Copy link
Collaborator Author

@TomazErjavec I had to trigger the action again with empty commit, now it seems to work

@matyaskopp, indeed, it did finish now, now checks are failing for some countries (e.g. EE, FR). However, I can't see why, maybe you can? It would be good (and expected) if the checks succeeded.

They are failing due to incomplete translations - I have switched to insisting on translations.

requireTaxonomiesTranslations: '${{ vars.REQUIRE_TRANSLATIONS }}'

it is customisable in settings: https://github.com/clarin-eric/ParlaMint/settings/variables/actions
image

Now we have IL fully translated, so I can switch it off if we don't want to motivate others to deliver their translations

@TomazErjavec
Copy link
Collaborator

@matyaskopp, thanks for explaining and illustrating!

Now we have IL fully translated, so I can switch it off if we don't want to motivate others to deliver their translations

I don't think they will be motivated by this, if they haven't done it in the scope of the project, they won't now either. On the other hand this makes it more difficult to find other problems. So, yes, I'd switch it off, at least for now. And - despite the explanation of how to do it - I'd rather let you press the magic button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants