-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data #887
base: main
Are you sure you want to change the base?
Data #887
Conversation
…, taxonomies, languages, faction events, orgNames, minister roles, unknown persons
main-data sync
…use the setup from fork)
Add IL Israeli Knesset Corpus sample
add template IL readme
@matyaskopp, what's happening to the checks? Are they stuck or merely take so long? |
@TomazErjavec I had to trigger the action again with empty commit, now it seems to work |
@matyaskopp, indeed, it did finish now, now checks are failing for some countries (e.g. EE, FR). However, I can't see why, maybe you can? It would be good (and expected) if the checks succeeded. |
They are failing due to incomplete translations - I have switched to insisting on translations. ParlaMint/.github/workflows/validate.yml Line 60 in 5f13b36
it is customisable in settings: https://github.com/clarin-eric/ParlaMint/settings/variables/actions Now we have IL fully translated, so I can switch it off if we don't want to motivate others to deliver their translations |
@matyaskopp, thanks for explaining and illustrating!
I don't think they will be motivated by this, if they haven't done it in the scope of the project, they won't now either. On the other hand this makes it more difficult to find other problems. So, yes, I'd switch it off, at least for now. And - despite the explanation of how to do it - I'd rather let you press the magic button. |
No description provided.