Make sure clashSimulation is False in HDL even with -O2 #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something probably changed since it was introduced. It would prefer to read the source instead of the precompiled module and always succeed, even with the original fix reverted.
The SpecConstr pass in GHC is able to poke through the OPAQUE of clashSimulation. Adding a noinline seems to block it from seeing the True inside. Fixes #2736
martijnbastiaan
approved these changes
Jun 30, 2024
martijnbastiaan
approved these changes
Jun 30, 2024
2 tasks
martijnbastiaan
added a commit
that referenced
this pull request
Jun 30, 2024
Make sure clashSimulation is False in HDL even with -O2 (copy #2737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2736
Also found that the test for #1796 was broken.
Still TODO: