Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inline let-bound recursive calls (copy #2844) #2850

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 26, 2024

This prevents recToLetRec from turning a globally recursive function into a local let-bound recursive function where the latter can be synthesized to hardware while the former cannot.

Fixes #2839

Still TODO:

@mergify mergify bot added the conflicts label Nov 26, 2024
Copy link
Author

mergify bot commented Nov 26, 2024

Cherry-pick of 0072241 has failed:

On branch mergify/copy/1.8/pr-2844
Your branch is up to date with 'origin/1.8'.

You are currently cherry-picking commit 00722413f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/2024-11-18T13_43_58+01_00_fix2839
	modified:   clash-lib/src/Clash/Normalize/Transformations/Inline.hs
	new file:   tests/shouldwork/Issues/T2839.hs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tests/Main.hs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

This prevents `recToLetRec` from turning a globally recursive
function into a local let-bound recursive function which can
be synthesized to hardware.

Fixes #2839

(cherry picked from commit 0072241)
@christiaanb christiaanb merged commit a11cb15 into 1.8 Nov 27, 2024
17 checks passed
@christiaanb christiaanb deleted the mergify/copy/1.8/pr-2844 branch November 27, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant