Fix CI for push events #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a push triggers a GitHub Action, it does not have the property `github.head_ref`, leading to an immediate failure. We generally solve this by falling back to `github.run_id`. Note that if it does fall back to run_id becasue head_ref was unset, the `cancel-in-progress` will not work since the run ID is unique for the run, so there will never be multiple runs in a single concurrency group. https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value Additionally, it is now possible to manually trigger a CI run. If the last run for the main branch was so long ago that its caches expired, and you open multiple PR's before merging one, each PR will have to rebuild all dependencies because they only can get their caches from the main branch or that specific PR. If you know this is what is going to happen, you could trigger a CI run on main to have fresh caches, and only open the PR's after that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a push triggers a GitHub Action, it does not have the property
github.head_ref, leading to an immediate failure. We generally solve this by falling back togithub.run_id.Note that if it does fall back to run_id becasue head_ref was unset, the
cancel-in-progresswill not work since the run ID is unique for the run, so there will never be multiple runs in a single concurrency group.https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value
Additionally, it is now possible to manually trigger a CI run. If the last run for the main branch was so long ago that its caches expired, and you open multiple PR's before merging one, each PR will have to rebuild all dependencies because they only can get their caches from the main branch or that specific PR. If you know this is what is going to happen, you could trigger a CI run on main to have fresh caches, and only open the PR's after that.