Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test program paths are hardcoded #38

Open
lmbollen opened this issue Nov 19, 2024 · 0 comments
Open

Test program paths are hardcoded #38

lmbollen opened this issue Nov 19, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lmbollen
Copy link
Member

The paths in clash-vexriscv-sim/tests/tests.hs are hardcoded relative to the project root.
This causes cabal run unittests tot fail for clash-vexriscv-sim when you are in the package directory.

We should rewrite this to either:

  • Dynamically find the project root use that as base path for the relative paths.
  • Move the files to the data-files segment of the package and use getDataFileName from the implicit Paths_clash_vexriscv_sim module.

Example: https://github.com/clash-lang/clash-vexriscv/blob/main/clash-vexriscv-sim/tests/Tests/Jtag.hs#L24-L52

@lmbollen lmbollen added bug Something isn't working good first issue Good for newcomers labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant