Add tests for existing key press dispatches and remove one jQuery call for volume focus (2/x) #839
+441
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh183
commented
Feb 17, 2025
| @@ -28,6 +28,17 @@ function VolumeControl({ muted = false, volume = true, dispatch }) { | |||
| } | |||
| }; | |||
|
|
|||
| const sliderRef = useRef(); | |||
There was a problem hiding this comment.
so there isn't a super elegant way to get around findElementById or $ when we want to mess with focus but useRef + useEffect with creating a function available to the entire window is a workaround of sorts.
https://www.reddit.com/r/react/comments/1b5nwoh/focusing_on_elements_programmatically_in_react/ - others seem to also converge around this
harsh183
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#777
useElementById,useImperativeHandle,PlayerDataglobal variable but this felt the neatest.