fix: crossnamespace remotecluster reference is not supported (#163)

* Update kamajicontrolplane_controller_externalreference.go * Update kamajicontrolplane_controller_externalreference.go
clastix · Jan 17, 2025 · ee29426 · ee29426
1 parent 5858271
commit ee29426
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/controllers/kamajicontrolplane_controller_externalreference.go b/controllers/kamajicontrolplane_controller_externalreference.go
@@ -31,12 +31,12 @@ var (
 
 //nolint:cyclop
 func (r *KamajiControlPlaneReconciler) extractRemoteClient(ctx context.Context, kcp v1alpha1.KamajiControlPlane) (client.Client, error) { //nolint:ireturn
-	if !r.FeatureGates.Enabled(features.ExternalClusterReference) &&
-		!r.FeatureGates.Enabled(features.ExternalClusterReferenceCrossNamespace) {
+	if !r.FeatureGates.Enabled(features.ExternalClusterReference)  {
 		return nil, ErrExternalClusterReferenceNotEnabled
 	}
 
-	if r.FeatureGates.Enabled(features.ExternalClusterReference) &&
+	if r.FeatureGates.Enabled(features.ExternalClusterReference) && 
+		!r.FeatureGates.Enabled(features.ExternalClusterReferenceCrossNamespace) &&
 		kcp.Spec.Deployment.ExternalClusterReference.KubeconfigSecretNamespace != "" &&
 		kcp.Spec.Deployment.ExternalClusterReference.KubeconfigSecretNamespace != kcp.Namespace {
 		return nil, ErrExternalClusterReferenceCrossNamespaceReference