Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: azure support #84

Merged
merged 5 commits into from
Nov 26, 2024
Merged

feat: azure support #84

merged 5 commits into from
Nov 26, 2024

Conversation

rpahli
Copy link
Contributor

@rpahli rpahli commented Feb 27, 2024

I tested the controller with azure and it worked out of the box. There are only some additional network components for the control plane which are not needed but also don#t hinder the cluster form working.

azure PR: kubernetes-sigs/cluster-api-provider-azure#4611

## Technical considerations

The Cluster API Azure infrastructure provider supports starting from [v1.13.0](https://github.com/kubernetes-sigs/cluster-api-provider-azure).
The Azure Cluster API operator will create some additional network components for the control plane which are not needed but do not hinder the cluster from working.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly something I was curious about: from my understanding, the CAPZ will create a Load Balancer that would then be used for the AzureCluster Control Plane Endpoint.

That resource would be billed despite not being used, even if you delete it since the CAPZ infrastructure controller will recreate it back, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try to remove the componenents. I can have a deeper look into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a PR on the azure operator

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost this message, link to the CAPZ PR: kubernetes-sigs/cluster-api-provider-azure#4611

docs/providers-azure.md Outdated Show resolved Hide resolved
@prometherion
Copy link
Member

I'm very keen on getting this supported by Kamaji, I'm just worried about the extra LBs we could get allocated since CAPZ doesn't allow skipping the generation of the Kubernetes API Server endpoint.

@rpahli I'm wondering if you're up to attending a CAPZ office hours meeting, explaining what we're looking to achieve, and finding a consensus in having the chance of disabling the LB reconciliation, at least for the API Server, it would be great.

Of course, I can co-lead the initiative with you, I'm not throwing you 🙃

@rpahli
Copy link
Contributor Author

rpahli commented Apr 3, 2024

My PR is currently in draft because the tests are missing. But I already using an operator form this build in our setup to provisions azure clusters with Kamaji.

Do you have some feedback from the CAPZ team regarding this feature?

Yes I think I can attend an office hours meetings and it would be great if you can co lead this event. 🙃

@prometherion
Copy link
Member

👋🏻 @rpahli I'd like to help you here with this, may I ask you to get in touch? You can find my contacts from LinkedIn, or by extracting the email address I use to sign my commits.

@prometherion
Copy link
Member

prometherion commented Nov 9, 2024

@rpahli sorry, I hadn't the time to give it a try, just wondering if there is some progress on this to get this merged soon, maybe with v0.13.0

@prometherion
Copy link
Member

We can skip the commit_lint, I'm going to squash the changes in a single commit.

@rpahli
Copy link
Contributor Author

rpahli commented Nov 26, 2024

lgtm

@prometherion prometherion merged commit 1669bed into clastix:master Nov 26, 2024
3 of 4 checks passed
@prometherion prometherion added this to the v0.13.0 milestone Nov 26, 2024
@rpahli rpahli deleted the azure branch November 26, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants