Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct labels in philim.f90 select statement. #660

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

ketch
Copy link
Member

@ketch ketch commented Jan 27, 2021

This fixes a bug introduced in b9706ae.

@ketch ketch mentioned this pull request Jan 27, 2021
@mandli
Copy link
Member

mandli commented Jan 27, 2021

I am not sure why but the builds are failing because packages that are look like they are correctly installed are subsequently not found, in this case h5py and mpirun. The changes look fine to me but it would not be great to at least see that the tests again pass before merging this.

@rjleveque
Copy link
Member

On my laptop the pyclaw tests now run fine except for shallow_sphere, which continues to give a seg fault as in #642.

The petclaw tests give me a bunch of errors saying

AttributeError: module 'clawpack.petclaw.fileio' has no attribute 'hdf5'

e.g.

======================================================================
ERROR: test_io.PetClawIOTest.test_io_from_hdf5
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/rjl/miniconda/envs/geo5/lib/python3.6/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/Users/rjl/D/clawpack_v5.8.0rc/pyclaw/src/pyclaw/tests/test_io.py", line 33, in test_io_from_hdf5
    self.read_write_and_compare(self.file_formats,regression_dir,'hdf5',1)
  File "/Users/rjl/D/clawpack_v5.8.0rc/pyclaw/src/pyclaw/tests/test_io.py", line 47, in read_write_and_compare
    ref_sol.read(frame_num,path=regression_dir,file_format=regression_format,read_aux=aux)
  File "/Users/rjl/D/clawpack_v5.8.0rc/pyclaw/src/pyclaw/solution.py", line 343, in read
    read_func = self.get_read_func(file_format)
  File "/Users/rjl/D/clawpack_v5.8.0rc/pyclaw/src/petclaw/solution.py", line 15, in get_read_func
    return fileio.hdf5.read
AttributeError: module 'clawpack.petclaw.fileio' has no attribute 'hdf5'
-------------------- >> begin captured logging << --------------------
root: DEBUG: No hdf5 support found.
root: DEBUG: No petsc support found.
--------------------- >> end captured logging << ---------------------

@mandli
Copy link
Member

mandli commented Jan 27, 2021

That just means that you do not have h5py installed (it's a confusing error message). I assume that you also probably do not have PETSc or petsc4py installed then either?

@ketch
Copy link
Member Author

ketch commented Jan 28, 2021

Actually, one of the Travis builds is also failing because it can't find h5py. It's strange, because the installation of hdf5-parallel with Conda appears to be successful.

@mandli
Copy link
Member

mandli commented Jan 28, 2021

Any thoughts as to why this is happening? As far as I can tell everything is getting installed correctly so the only thing that comes to mind is that there is a path problem and something has changed the way that conda and Travis interact.

@ketch
Copy link
Member Author

ketch commented Jan 31, 2021

I have not been able to uncover what is going on with the Conda install of MPI and HDF5. I don't see how it could possibly be related to this PR, so I'm in favor of merging this. I've raised an issue:

#661

@mandli
Copy link
Member

mandli commented Jan 31, 2021

I support this as well. I can send a message to one of the conda developers as well and see if they have an idea.

@mandli mandli merged commit 97789e5 into clawpack:master Jan 31, 2021
rjleveque added a commit to rjleveque/clawpack that referenced this pull request Jan 31, 2021
Fixed bug in philim but travis not passing due to mpi/hdf5 issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants