Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JCP GeoClaw Riemann solver #111

Merged
merged 4 commits into from
Dec 21, 2016
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modify fw(3,:) in riemann_aug_JCP geoclaw solver to put transverse ve…
…locity jump into fw(3,1) or fw(3,3) depending on interface velocity rather than into fw(3,2), as suggested by Wenwen Li.

This avoids some cases where transverse velocity does not propagate past jump in bathymetry, may improve some instability issues.
  • Loading branch information
rjleveque committed Jun 4, 2016
commit 9c02ede506c8a4ea43578b1eea1c38f5f9fade60
11 changes: 10 additions & 1 deletion src/geoclaw_riemann_utils.f
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,18 @@ subroutine riemann_aug_JCP(maxiter,meqn,mwaves,hL,hR,huL,huR,
fw(3,mw)=beta(mw)*r(2,mw)
enddo
!find transverse components (ie huv jumps).
! MODIFIED from 5.3.1 version
fw(3,1)=fw(3,1)*vL
fw(3,3)=fw(3,3)*vR
fw(3,2)= hR*uR*vR - hL*uL*vL - fw(3,1)- fw(3,3)
fw(3,2)= 0.d0

hustar_interface = huL + fw(1,1) ! = huR - fw(1,3)
if (hustar_interface <= 0.0d0) then
fw(3,1) = fw(3,1) + (hR*uR*vR - hL*uL*vL - fw(3,1)- fw(3,3))
else
fw(3,3) = fw(3,3) + (hR*uR*vR - hL*uL*vL - fw(3,1)- fw(3,3))
end if


return

Expand Down