Add dictionary of fwave values to static.py. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to automatically set solver.fwave for most solvers.
|
I wonder if there is a better way to do this from the Riemann solver (query it to see what kind of solver it is) but that's for another time and a future us problem. |
|
Yes, if all of the Riemann solvers were objects with data attached then this information could belong directly to them. But f2py doesn't play so well with fortran modules so I have no inclination to try to do that. And this solution is simple and effective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to automatically set solver.fwave for most solvers.
This addresses the first part of clawpack/pyclaw#737.