Build: Suppress JNI warnings from Java 24 for CLI and i2psnark-standa…

…lone and add note to wrapper.config on how to do it there for normal runtime
clayne · Nov 28, 2024 · a1949bf · a1949bf
1 parent f7d2893
commit a1949bf
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 0 deletions.
diff --git a/apps/i2psnark/java/build.xml b/apps/i2psnark/java/build.xml
@@ -261,6 +261,11 @@
             <attribute name="Workspace-Changes" value="${workspace.changes.tr}" />
             <attribute name="X-Compile-Source-JDK" value="${javac.version}" />
             <attribute name="X-Compile-Target-JDK" value="${javac.version}" />
+            <!--
+               Suppress JNI warning in JRE 24+, and eventual restriction
+               See https://openjdk.org/jeps/472
+             -->
+            <attribute name="Enable-Native-Access" value="ALL-UNNAMED" />
             <!-- this is so Jetty will report its version correctly -->
             <section name="org/eclipse/jetty/server/" >
                 <attribute name="Implementation-Vendor" value="Eclipse.org - Jetty" />

diff --git a/core/java/build.xml b/core/java/build.xml
@@ -129,6 +129,13 @@
                 <attribute name="Workspace-Changes" value="${workspace.changes.tr}" />
                 <attribute name="X-Compile-Source-JDK" value="${javac.version}" />
                 <attribute name="X-Compile-Target-JDK" value="${javac.version}" />
+                <!--
+                   Suppress JNI warning in JRE 24+, and eventual restriction
+                   See https://openjdk.org/jeps/472
+                   This only works for CLI with this as the named -jar argument;
+                   for normal runtime it must be suppressed in wrapper.config
+                 -->
+                <attribute name="Enable-Native-Access" value="ALL-UNNAMED" />
             </manifest>
         </jar>
     </target>

diff --git a/installer/resources/wrapper.config b/installer/resources/wrapper.config
@@ -77,6 +77,13 @@ wrapper.java.additional.1=-DloggerFilenameOverride=logs/[email protected]
 wrapper.java.additional.2=-Di2p.dir.base="$INSTALL_PATH"
 wrapper.java.additional.2.stripquotes=TRUE
 
+# Suppress JNI warning in JRE 24+, and eventual restriction
+# See https://openjdk.org/jeps/472
+# This will fail on JRE 11 or lower, works on JRE 17+
+#wrapper.java.additional.3=--enable-native-access=ALL-UNNAMED
+# Alternative that _may_ work on all JRE versions:
+#set.JDK_JAVA_OPTIONS=--enable-native-access=ALL-UNNAMED
+
 # Prevent the JVM from exporting stats (and thereby causing hundreds of
 # ms long pauses during GC)
 # http://www.evanjones.ca/jvm-mmap-pause.html

diff --git a/router/java/build.xml b/router/java/build.xml
@@ -99,6 +99,13 @@
                 <attribute name="Workspace-Changes" value="${workspace.changes.tr}" />
                 <attribute name="X-Compile-Source-JDK" value="${javac.version}" />
                 <attribute name="X-Compile-Target-JDK" value="${javac.version}" />
+                <!--
+                   Suppress JNI warning in JRE 24+, and eventual restriction
+                   See https://openjdk.org/jeps/472
+                   This only works for CLI with this as the named -jar argument;
+                   for normal runtime it must be suppressed in wrapper.config
+                 -->
+                <attribute name="Enable-Native-Access" value="ALL-UNNAMED" />
             </manifest>
         </jar>
     </target>