Fix orientation of transform to image coordinate system #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Orientation of coordinate system was lhs for image coord system while it was rhs in the world coordinate system. - `write_obj_with_colors` swapped the x and y coordinates - with new implementation ply and obj files are consistent and with correct handedness
cleardusk
reviewed
Feb 14, 2020
| if transform: | ||
| # transform to image coordinate space (z pointing away from camera) | ||
| vertex[1, :] = std_size + 1 - vertex[1, :] | ||
| vertex[2, :] *= -1 # ensuring rhs coordinate system |
There was a problem hiding this comment.
Reversing z-axis may bring inconsistency with other parts, e.g. rendering part. There may be alternative solutions and I will check it recently.
There was a problem hiding this comment.
I agree one might has to check/fix the renderer, sorry didn't had time to dig deeper atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while it was rhs in the world coordinate system.
write_obj_with_colorsswapped the x and y coordinatescorrect handedness
Closes #138