Update README.md #12
Open
Update README.md #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtomlinson
reviewed
Jun 28, 2023
mongo_seed/README.md
Outdated
| ### To push latest image to Docker Hub | ||
| 1. Log into docker | ||
|
|
||
| `docker login -u clearlydefined -p <PASSWORD_FROM_KEYVAULT` |
There was a problem hiding this comment.
missing '>' at the end
qtomlinson
reviewed
Apr 2, 2024
mongo_seed/README.md
Outdated
|
|
||
| 4. Build and tag image | ||
|
|
||
| `docker build -t clearlydefined/docker_dev_env_experiment_clearlydefined_mongo_seed:latest` |
There was a problem hiding this comment.
Suggested change
| `docker build -t clearlydefined/docker_dev_env_experiment_clearlydefined_mongo_seed:latest` | |
| `docker build -t clearlydefined/docker_dev_env_experiment_clearlydefined_mongo_seed:latest .` |
mongo_seed/README.md
Outdated
|
|
||
| `docker login -u clearlydefined -p <PASSWORD_FROM_KEYVAULT` | ||
| 2. Pull latest code from GitHub repo | ||
| 3. Build latest image |
There was a problem hiding this comment.
This might be redundant. "Build and tag image" might be enough
Merged
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.