Move symlinks into clearpath-robot.service.wants instead of multi-user.target.wants
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider to create symlinks in clearpath-robot.wants
civerachb-cpr
requested review from
roni-kreinin,
luis-camero and
hilary-luo
and removed request for
a team and
luis-camero
hilary-luo
approved these changes
Apr 8, 2025
luis-camero
pushed a commit
that referenced
this pull request
Apr 8, 2025
…user.target.wants` (#187) * Add clearpath-robot.servce symlink to multi-user.wants, add a new provider to create symlinks in clearpath-robot.wants * provider -> Provider * Fix moving the symlink * clearpath-robot.target -> clearpath-robot.service * Update the post-install instructions to add systemctl-enable * Fix the symlink generated by the RobotProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new
systemdprovider that doesn't explicitly add symlinks tomulti-user.target.wants, use this provider to create the sub-jobs that are part of theclearpath-robot.servicejob.Fix the symlink generated by
RobotProviderso it properly creates the main job symlink inmulti-user.target.wants.Resolves RPSW-2228