Add: Chinese Language #137
Conversation
|
I know there are definitely some problems in this pr, please tell me and let me fix it. |
I don't mind per se, as long as the ISS compiler accepts it. |
Let me know when it's ready for review. I'll convert it to Draft in the meantime. |
|
Forgot to mention this earlier, but: thanks, that's awesome! 😄 I'll create an issue to track this in HISTORY. |
To display Chinese Hanzi See issue clechasseur#137
|
Thank you, now you can review it~ |
Installer/Setup.iss
Outdated
| @@ -81,6 +81,7 @@ SignTool=certum | |||
| [Languages] | |||
| Name: en_CA; MessagesFile: compiler:Default.isl | |||
| Name: fr_CA; MessagesFile: compiler:Languages\French.isl | |||
| Name: zh-CN; MessagesFile: compiler:Languages\Chinese.isl | |||
There was a problem hiding this comment.
This is the reason the build fails - the language name cannot have hyphens, so you must rename it to zh_CN (underscore instead of hyphen).
There was a problem hiding this comment.
I'll review the rest once I have more time. Thank you! 😄
Fix hyphens typo
|
It seems the build still fails on CI because it cannot find the "Chinese.isl" file from the Inno Setup's installation directory. Is this a regular file included with Inno or is it added by something else? I'm not on my PC so can't check if I have it locally or not... |
|
By the way, sorry for my slow response speed, personal life is very hectic these days, but I still want to merge this. |
|
It's okay, don't rush to merge 😃, we can wait for there is no problem and then merge it . Since I'm not familiar with the isl application 🤣, what I did is just found the places that might relates ti18n and modified them 🤣 |
I'll check when I'm on my PC to make sure this file exists. Perhaps it's named differently. |
|
I've checked on my PC earlier and there's no official Chinese translation for Inno Setup. However, there is an unofficial one for Chinese (Simplified) here: https://jrsoftware.org/files/istrans/ Try downloading this file and including it in your PR instead of referring to the one shipped with the compiler and see how it goes. |
clechasseur
force-pushed
the
default
branch
2 times, most recently
from
a6f832e to
1e71272
Compare
|
ok, i'll update this pr ❤ |
Hi, the setup.iss file use Windows 1252 Character Encoding, the Hanzi can not display, can we change it into UTF-8 encoding?