Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: When creating a SAML Connection you are also required to provide the provider type #207

Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat!: When creating a SAML Connection you are also required to provide the provider type #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clerk/saml_connections.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ func (s SAMLConnectionsService) Read(id string) (*SAMLConnection, error) {
type CreateSAMLConnectionParams struct {
Name string `json:"name"`
Domain string `json:"domain"`
Provider string `json:"provider"`
IdpEntityID *string `json:"idp_entity_id,omitempty"`
IdpSsoURL *string `json:"idp_sso_url,omitempty"`
IdpCertificate *string `json:"idp_certificate,omitempty"`
Expand Down
1 change: 1 addition & 0 deletions clerk/saml_connections_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ func TestSAMLConnectionsService_Create(t *testing.T) {
createParams := &CreateSAMLConnectionParams{
Name: "Testing SAML",
Domain: "example.com",
Provider: "saml_custom",
IdpEntityID: stringToPtr("test-idp-entity-id"),
IdpSsoURL: stringToPtr("https://example.com/saml/sso"),
IdpCertificate: stringToPtr(dummySAMLConnectionCertificate),
Expand Down
Loading