Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clerk-js): Remove setActive() call from signOut() #5171

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

fix(clerk-js): Remove setActive() call from signOut() #5171

wants to merge 15 commits into from

Conversation

brkalow
Copy link
Member

@brkalow brkalow commented Feb 14, 2025

Description

Removes setActive() call from signOut() implementation, fixing a number of bugs related to sign out.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 5e690cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 3:28pm

@brkalow brkalow requested a review from a team February 18, 2025 23:31
@brkalow brkalow marked this pull request as ready for review February 18, 2025 23:31
@panteliselef
Copy link
Member

!snapshot

1 similar comment
@panteliselef
Copy link
Member

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/agent-toolkit 0.0.4-snapshot.v20250219140158
@clerk/astro 2.3.0-snapshot.v20250219140158
@clerk/backend 1.24.3-snapshot.v20250219140158
@clerk/chrome-extension 2.2.11-snapshot.v20250219140158
@clerk/clerk-js 5.54.0-snapshot.v20250219140158
@clerk/elements 0.23.0-snapshot.v20250219140158
@clerk/clerk-expo 2.8.0-snapshot.v20250219140158
@clerk/expo-passkeys 0.1.22-snapshot.v20250219140158
@clerk/express 1.3.50-snapshot.v20250219140158
@clerk/fastify 2.1.23-snapshot.v20250219140158
@clerk/localizations 3.10.8-snapshot.v20250219140158
@clerk/nextjs 6.12.1-snapshot.v20250219140158
@clerk/nuxt 1.2.1-snapshot.v20250219140158
@clerk/clerk-react 5.24.0-snapshot.v20250219140158
@clerk/react-router 1.1.1-snapshot.v20250219140158
@clerk/remix 4.5.1-snapshot.v20250219140158
@clerk/shared 2.23.0-snapshot.v20250219140158
@clerk/tanstack-start 0.10.1-snapshot.v20250219140158
@clerk/testing 1.4.24-snapshot.v20250219140158
@clerk/themes 2.2.20-snapshot.v20250219140158
@clerk/types 4.47.0-snapshot.v20250219140158
@clerk/ui 0.3.25-snapshot.v20250219140158
@clerk/vue 1.3.0-snapshot.v20250219140158

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/[email protected] --save-exact

@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/expo-passkeys

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/nuxt

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/react-router

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@clerk/ui

npm i @clerk/[email protected] --save-exact

@clerk/vue

npm i @clerk/[email protected] --save-exact

@panteliselef
Copy link
Member

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/agent-toolkit 0.0.4-snapshot.v20250220111059
@clerk/astro 2.3.0-snapshot.v20250220111059
@clerk/backend 1.24.3-snapshot.v20250220111059
@clerk/chrome-extension 2.2.11-snapshot.v20250220111059
@clerk/clerk-js 5.54.0-snapshot.v20250220111059
@clerk/elements 0.23.0-snapshot.v20250220111059
@clerk/clerk-expo 2.8.0-snapshot.v20250220111059
@clerk/expo-passkeys 0.1.22-snapshot.v20250220111059
@clerk/express 1.3.50-snapshot.v20250220111059
@clerk/fastify 2.1.23-snapshot.v20250220111059
@clerk/localizations 3.10.8-snapshot.v20250220111059
@clerk/nextjs 6.12.1-snapshot.v20250220111059
@clerk/nuxt 1.2.1-snapshot.v20250220111059
@clerk/clerk-react 5.24.0-snapshot.v20250220111059
@clerk/react-router 1.1.1-snapshot.v20250220111059
@clerk/remix 4.5.1-snapshot.v20250220111059
@clerk/shared 2.23.0-snapshot.v20250220111059
@clerk/tanstack-start 0.10.1-snapshot.v20250220111059
@clerk/testing 1.4.24-snapshot.v20250220111059
@clerk/themes 2.2.20-snapshot.v20250220111059
@clerk/types 4.47.0-snapshot.v20250220111059
@clerk/ui 0.3.25-snapshot.v20250220111059
@clerk/vue 1.3.0-snapshot.v20250220111059

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/[email protected] --save-exact

@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/expo-passkeys

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/nuxt

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/react-router

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@clerk/ui

npm i @clerk/[email protected] --save-exact

@clerk/vue

npm i @clerk/[email protected] --save-exact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clerk-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brkalow @panteliselef @clerk-cookie