Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clerk-js,types): Navigate to after-auth tasks #5187

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat(clerk-js,types): Navigate to after-auth tasks #5187

wants to merge 12 commits into from
+493 −16

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Feb 17, 2025 •
edited
Loading

Description

Resolves ORGS-562

  • Displays the current pending session task as a SignIn/SignUp routes
  • Introduce client-side navigation once session updates to pending with tasks

After sign-in

CleanShot.2025-02-19.at.15.43.57.mp4

After sign-up

CleanShot.2025-02-19.at.15.45.42.mp4

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Feb 17, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3e274ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 7:04pm

@LauraBeatris LauraBeatris changed the title [wip] feat(clerk-js): Display pending tasks on SignIn/SignUp [wip] chore(clerk-js): Display pending tasks on SignIn/SignUp Feb 17, 2025
@LauraBeatris LauraBeatris force-pushed the introduce-session-tasks-types branch from e2e02ec to aa2c20a Compare February 18, 2025 16:26
Base automatically changed from introduce-session-tasks-types to main February 18, 2025 16:35
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 59a2b22 to e836ee1 Compare February 18, 2025 16:39
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 62a62ae to 639e7f8 Compare February 18, 2025 21:13
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 755c683 to 4a6e892 Compare February 18, 2025 22:45
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 4a6e892 to a1c1c39 Compare February 18, 2025 23:26
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch 2 times, most recently from d27d8c9 to 104791b Compare February 18, 2025 23:31
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 104791b to 48191f1 Compare February 19, 2025 01:21
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 48191f1 to d74f3e7 Compare February 19, 2025 01:28
LauraBeatris
LauraBeatris commented Feb 19, 2025
View reviewed changes
packages/types/src/session.ts
@@ -197,7 +198,7 @@ export interface PublicUserData {
}

export interface SessionTask {
key: 'orgs';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAPI was previously returning orgs but it got updated to org

@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from d74f3e7 to 08a8aff Compare February 19, 2025 01:32
@LauraBeatris LauraBeatris changed the title chore(clerk-js,types): Display after-auth tasks on SignIn/SignUp chore(clerk-js,types): Navigate to after-auth tasks on SignIn/SignUp Feb 20, 2025
@LauraBeatris LauraBeatris changed the title chore(clerk-js,types): Navigate to after-auth tasks on SignIn/SignUp feat(clerk-js,types): Navigate to after-auth tasks on SignIn/SignUp Feb 20, 2025
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 3032ea7 to 4a59b37 Compare February 20, 2025 20:43
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 4a59b37 to 1120aa0 Compare February 20, 2025 21:26
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 1120aa0 to 07f897c Compare February 20, 2025 21:35
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 384c009 to adf7f0c Compare February 20, 2025 22:29
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from adf7f0c to 0bf1772 Compare February 20, 2025 22:34
@LauraBeatris LauraBeatris changed the title feat(clerk-js,types): Navigate to after-auth tasks on SignIn/SignUp feat(clerk-js,types): Handle to after-auth tasks after sign-in/sign-up Feb 20, 2025
@LauraBeatris LauraBeatris changed the title feat(clerk-js,types): Handle to after-auth tasks after sign-in/sign-up feat(clerk-js,types): Navigate to after-auth tasks Feb 20, 2025
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 0bf1772 to 566fd8c Compare February 20, 2025 23:18
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from 566fd8c to 5d55006 Compare February 21, 2025 12:46
panteliselef
panteliselef reviewed Feb 21, 2025
View reviewed changes
packages/types/src/session.ts
@@ -197,7 +198,7 @@ export interface PublicUserData {
}

export interface SessionTask {
key: 'orgs';
key: 'org';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is scope a better name ? or does key represent something else ?

@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from bd5cdcf to fcd72b5 Compare February 21, 2025 18:45
@LauraBeatris LauraBeatris force-pushed the laura/tasks-sign-sign-up-routes branch from fcd72b5 to 3e274ee Compare February 21, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panteliselef panteliselef panteliselef left review comments

@octoper octoper Awaiting requested review from octoper

@brkalow brkalow Awaiting requested review from brkalow

At least 1 approving review is required to merge this pull request.

Assignees

@LauraBeatris LauraBeatris

Labels
clerk-js react types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LauraBeatris @panteliselef @clerk-cookie