Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix serde rename clause #9

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

quartztz
Copy link
Contributor

@quartztz quartztz commented Oct 9, 2024

Fix the serde rename clause used when constructing the poll, so that the names that are taken are the committee members' first names instead of their last names.

Copy link
Contributor

@Thechi2000 Thechi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queried fields should also be updated, on line 48.

@quartztz
Copy link
Contributor Author

quartztz commented Oct 9, 2024

Missed it ! sorry, i didn't expect the request to be hardcoded 0:)

jokes aside: thanks for spotting it :3

@quartztz quartztz requested a review from Thechi2000 October 9, 2024 09:03
Copy link
Contributor

@Thechi2000 Thechi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix :)

@Thechi2000 Thechi2000 merged commit efa43d8 into clicepfl:main Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants