ringring init #16
Merged
ringring init #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshaio
reviewed
Jan 29, 2024
| const headers = {}; | ||
|
|
||
| const inputMapping = { | ||
| 'apiKey': input['apiKey'], |
There was a problem hiding this comment.
I noticed that the apikey is present in this file. Could you please move it to the auth.js file?
There was a problem hiding this comment.
Please see https://github.com/clientIO/appmixer-components/issues/1661#issuecomment-1914767748 where I mentioned this. The problem is that OpenAPI spec doesn't support apiKey in body.
There was a problem hiding this comment.
Before releasing the generator, we need to improve it or change the code.
There was a problem hiding this comment.
Based on today's discussion we don't need to do any changes to the generator. When specified like this with apiKey in body we simply won't use Authentication section for the component.
vtalas
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/clientIO/appmixer-components/issues/1661
Done
timeScheduledandtimeValidityNotes
auth.jsfile. TheapiKeyneeds to be a part of the body of the POST request to/sms/v1/message. Due to this, there is no authentication section for the component. Appmixer is not keeping track of any connected accounts.