feat: implement libavoid example in angular #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/avoid-router.service.ts
Outdated
There was a problem hiding this comment.
Maybe better to call this AvoidRouterLoader because it is not used anywere except in the initializer. And you don't need to depend on it in appComponent if you are not using it, I believe.
There was a problem hiding this comment.
I think we should keep the name with the word "Service" since that is what is used in all the tutorials and hopefully it makes it clear that other libraries (which may need to call the service in the component) can be used in this way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements JointJS's libavoid example in Angular, using the main branch of joint-plus-tutorial-angular as a base.
Uses this guide for reference.