-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(joint-vitest-plugin-mock-svg): Add new plugin #2863
Open
zbynekstara
wants to merge
18
commits into
clientIO:master
Choose a base branch
from
zbynekstara:joint-mock-svg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynekstara
changed the title
WIP: feat(joint-vite-plugin-mock-svg): Add new plugin
feat(joint-vitest-plugin-mock-svg): Add new plugin
Feb 3, 2025
zbynekstara
force-pushed
the
joint-mock-svg
branch
from
February 4, 2025 12:16
bb2bfa4
to
4ae408a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Vitest plugin to mock SVG global constants required for JointJS testing. Importing this plugin will solve issues such as #2824.
This PR includes React and Vue E2E tests, which can be run via
yarn run test
(needsyarn install
+yarn run dist
on the package +yarn run dist
on joint-core).Note
If you get error
Failed to resolve entry for package "@joint/vitest-plugin-mock-svg". The package may have incorrect main/module/exports specified in its package.json. [plugin externalize-deps]
, it means that you have not runyarn run dist
inside thejoint-vitest-plugin-mock-svg
package. See above for instructions