Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize: Standardize UpdateStatus #82

Closed
wants to merge 1 commit into from

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented Aug 19, 2024

Part of #80

Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: 18ace0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Aug 19, 2024

commit: 18ace0d

yarn add https://pkg.pr.new/@clockworklabs/spacetimedb-sdk@82

Open in Stackblitz

Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion out-of-band, we should not manually edit autogenerated files (except where absolutely necessary, as described in DEVELOP.md). I also question the value of changing our codegen to simplify the TS -> JS transformation, but if you have time to spend on that I won't object, so long as you do so appropriately by editing the CLI codegen instead of hand-editing autogenerated files.

@PuruVJ
Copy link
Collaborator Author

PuruVJ commented Aug 19, 2024

Closing as these changes should be in codegen, not the SDK

@PuruVJ PuruVJ closed this Aug 19, 2024
@PuruVJ PuruVJ deleted the modernize/update+status branch August 19, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants