Home and OCP Page #102
Home and OCP Page #102
Conversation
local-compose.sh
Outdated
| @@ -11,9 +11,11 @@ CPT_CONFIG=${CPT_CONFIG:-"$PWD/backend/ocpperf.toml"} | |||
| podman rm -f front back | |||
|
|
|||
| podman build -f backend/backend.containerfile --tag backend | |||
| podman build -f frontend/frontend.containerfile --tag frontend | |||
| # podman build -f frontend/frontend.containerfile --tag frontend | |||
There was a problem hiding this comment.
This needs to be un-commented i believe
|
@MVarshini Can you also get our recent |
There was a problem hiding this comment.
Great job @MVarshini!!
There are a couple of problems I found:
- Seems that the Sorting on the columns is not working on any page
- The values on the filters seem to repeat, I see in some
FALSEandfalseboth filter the same
And a couple of requests:
- Can we make filters multi-select?
- Can we recalculate the values on the filters based on the selected filter values?
|
@chentex Thanks for the suggestions. I'll address the mentioned issues. |
|
@MVarshini |
frontend/src/App.jsx
Outdated
| @@ -20,7 +21,7 @@ function App() { | |||
| <Route element={<MainLayout />}> | |||
| <Route index element={<Home />} /> | |||
| <Route path={APP_ROUTES.HOME} element={<Home />} /> | |||
| <Route path={APP_ROUTES.OCP} element={<Home />} /> | |||
| <Route path={APP_ROUTES.OCP} element={<OCP />} /> | |||
| <Route path={APP_ROUTES.QUAY} element={<Home />} /> | |||
There was a problem hiding this comment.
Wrong mapping here. Also telco doesn't seem to be added here.
There was a problem hiding this comment.
@MVarshini assuming that we have plans to write up frontend reducers and actions for Quay and Telco in the subsequent PRs, these changes look good to me.
|
As we talked with @MVarshini |
Type of change
Description
This PR has the Home and CPT page Tables with Filters, sorting, dynamic column selection and pagination
Related Tickets & Documents
Checklist before requesting a review
Testing