-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-select Filter #109
Multi-select Filter #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MVarshini Thank you for this it is working well, can I just ask for one more change.
Can we leave teh summary fields as a single select, that if you click one the status filters resets just to that one.
Right now if I click success, the success filter applies, and if I click failure, the failure status appends to the filter, I would like it to remove the success one and set it to failure. I don't know if it makes sense.
@chentex That sounds right. Updated the status filter in the Metrics tab as requested. |
Looks like along with summary fields, the same change got applied to other's as well, for example |
Hi @vishnuchalla, I've reviewed the PR and I see it working as expected, can you explain what changes are you seeing in other fields as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MVarshini Regarding filters dropdown select, when I go select an option from the Product
or any other option drop down filter, I have to deselect it's value to see rest of the values available otherwise I see only the current selected value as a part of dropdown. Example below.
Can you enable it with multi-select option please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
As per our discussion offline, my filters concern got addressed. Thanks @MVarshini |
Type of change
Description
This PR allows the user to select multiple filter values and based on selection other filter options get recalculated.
Related Tickets & Documents
Checklist before requesting a review
Testing