Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-select Filter #109

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

MVarshini
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

This PR allows the user to select multiple filter values and based on selection other filter options get recalculated.

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@MVarshini MVarshini self-assigned this Jul 16, 2024
Copy link
Member

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MVarshini Thank you for this it is working well, can I just ask for one more change.
Can we leave teh summary fields as a single select, that if you click one the status filters resets just to that one.

Right now if I click success, the success filter applies, and if I click failure, the failure status appends to the filter, I would like it to remove the success one and set it to failure. I don't know if it makes sense.

@MVarshini
Copy link
Collaborator Author

Hi @MVarshini Thank you for this it is working well, can I just ask for one more change. Can we leave teh summary fields as a single select, that if you click one the status filters resets just to that one.

Right now if I click success, the success filter applies, and if I click failure, the failure status appends to the filter, I would like it to remove the success one and set it to failure. I don't know if it makes sense.

@chentex That sounds right. Updated the status filter in the Metrics tab as requested.

@vishnuchalla
Copy link
Collaborator

vishnuchalla commented Jul 30, 2024

Hi @MVarshini Thank you for this it is working well, can I just ask for one more change. Can we leave teh summary fields as a single select, that if you click one the status filters resets just to that one.
Right now if I click success, the success filter applies, and if I click failure, the failure status appends to the filter, I would like it to remove the success one and set it to failure. I don't know if it makes sense.

@chentex That sounds right. Updated the status filter in the Metrics tab as requested.

Looks like along with summary fields, the same change got applied to other's as well, for example Product etc. Was that expected?

@chentex
Copy link
Member

chentex commented Jul 30, 2024

Hi @vishnuchalla, I've reviewed the PR and I see it working as expected, can you explain what changes are you seeing in other fields as well?
Maybe the confusion is with my last comment where I requested the changes on the summary fields, but the multiselect should be applied to all filters.

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MVarshini Regarding filters dropdown select, when I go select an option from the Product or any other option drop down filter, I have to deselect it's value to see rest of the values available otherwise I see only the current selected value as a part of dropdown. Example below.

Screenshot from 2024-07-31 13-20-56

Can you enable it with multi-select option please?

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vishnuchalla vishnuchalla merged commit 4f2383e into cloud-bulldozer:revamp Aug 6, 2024
1 check passed
@vishnuchalla
Copy link
Collaborator

As per our discussion offline, my filters concern got addressed. Thanks @MVarshini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants