Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating actions to get triggered only on main branch #110

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Jul 18, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Making code changes to trigger github actions only on the main branch.

Related Tickets & Documents

At present we have github actions being triggered for every single push, which lead changes in revamp branch go into dev, breaking the dashboard

# ls
README.md  frontend.containerfile  index.html  jsconfig.json  node_modules  package-lock.json  package.json  public  src  vite.config.js

And this was the action responsible for it: https://github.com/cloud-bulldozer/cpt-dashboard/actions/runs/9953308824/job/27496484697

potential solution is to update this workflow file to only publish images on target branch main not for others which happened to be revamp as the latest from the action above.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Needs this PR to be merged in order to see if it works with github actions runner.

@vishnuchalla vishnuchalla requested review from jtaleric and chentex July 18, 2024 12:02
Copy link
Member

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnuchalla vishnuchalla merged commit 8379169 into cloud-bulldozer:main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants