Including Grafana Links #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
local-compose.sh
Outdated
| @@ -11,7 +11,7 @@ CPT_CONFIG=${CPT_CONFIG:-"$PWD/backend/ocpperf.toml"} | |||
| podman rm -f front back | |||
|
|
|||
| podman build -f backend/backend.containerfile --tag backend | |||
| podman build -f frontend/frontend.containerfile --tag frontend | |||
| # podman build -f frontend/frontend.containerfile --tag frontend | |||
There was a problem hiding this comment.
For testing this PR perhaps?
| var min = ("0" + (d.getMinutes())).slice(-2); | ||
| var sec = ("0" + (d.getSeconds())).slice(-2); | ||
| return year + "-" + month + "-" + day + " " + hour + ":" + min + ":" + sec; | ||
| let year = d.getFullYear(); |
There was a problem hiding this comment.
just curious, does it matter between var vs let?
There was a problem hiding this comment.
Using var variables can be re-declared and updated within the same scope but with let variables can be updated but can't be re-declared in the same scope.
chentex
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Appart from the commented podman build all looking good!! Thank you @MVarshini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Based on the systems build Grafana URL and display it on row expansion in OCP page table
Related Tickets & Documents
Checklist before requesting a review
Testing