Quay and Telco Tabs #112
Quay and Telco Tabs #112
Conversation
frontend/src/actions/quayActions.js
Outdated
| pretty: true, | ||
| start_date: "2022-08-16", | ||
| end_date: "2024-08-16", | ||
| // ...(start_date && { start_date }), |
There was a problem hiding this comment.
Can we cleanup this?
|
@MVarshini There isn't any trace for splunk dashboard links for telco here. Can we get them added in this PR as well please? |
frontend/src/actions/types.js
Outdated
| export const SET_TELCO_SORT_DIR = "SET_TELCO_SORT_DIR"; | ||
| export const SET_TELCO_PAGE = "SET_TELCO_PAGE"; | ||
| export const SET_TELCO_PAGE_OPTIONS = "SET_TELCO_PAGE_OPTIONS"; | ||
| export const SET_TELCO_INIT_JOBS = "SET_OCP_INIT_JOBS"; |
There was a problem hiding this comment.
Is this action appropriate here?
There was a problem hiding this comment.
Wow, this is definitely a new App! thanks for the effort @MVarshini!!!
Apart from the comments that @vishnuchalla, the only other thing I noticed is this:
- I am in
Quaypage and it loads the jobs. - Move to
Telcopage, but for the current dates there are no jobs - table in
Telcocontinues to show theQuayjob list
I used the dates 24.Aug to 26.Aug in Telco
- Also happens if I am in
Telcoand it's showing data from the 16.Aug to 26.Aug, and the update to 24.Aug to 26.Aug
I guess it's just the cleanup part of the table.
Again thank you very much for this changes @MVarshini !!
frontend/src/actions/types.js
Outdated
| export const SET_QUAY_SORT_DIR = "SET_QUAY_SORT_DIR"; | ||
| export const SET_QUAY_PAGE = "SET_QUAY_PAGE"; | ||
| export const SET_QUAY_PAGE_OPTIONS = "SET_QUAY_PAGE_OPTIONS"; | ||
| export const SET_QUAY_INIT_JOBS = "SET_OCP_INIT_JOBS"; |
There was a problem hiding this comment.
I think this one is still crossed named
@chentex Thanks for the catch. Updated the code. Please check |
|
|
Type of change
Description
This PR includes Quay and Telco Tabs
Related Tickets & Documents
PANDA-556
Checklist before requesting a review
Testing