Random Pagination ISSUE-143

[MVarshini]

Random Pagination not working

Type of change

• Refactor
• New feature
• Bug fix
• Optimization
• Documentation Update

Description

Pagination on clicking first and last buttons not working

Related Tickets & Documents

• Related Issue #
• Closes REVAMP branch random pagination #143

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

Testing

• Please describe the System Under Test.
• Please provide detailed steps to perform tests related to this code change.
• How were the fix/results from this change verified? Please provide relevant screenshots or results.

[dbutenhof]

In some APIs (and you added some more with this PR), you're protecting against having offset set to a value without size. That's not the case here, and this expression isn't considering the value of offset. So if size we add offset + size (regardless of offset) or else use 0.

Is that what you meant? Should you be raising the HTTPException here if offset and not size?

>>> offset = 10
>>> size = None
>>> offset + size if size else 0
0
>>> offset + (size if size else 0)
10