-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add RHOAI Notebooks Performance tests to the HOME page #84
Conversation
…s: mute chatty log comment
…l OpenSearch (for debugging)
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 6 days with no activity. |
Bad bot. |
@kpouget is this still being worked on? |
it's on hold, too many things to do, too few persons! |
if df.empty: | ||
return df | ||
|
||
df["startDate"] = df["metadata.start"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove these metadata.*
columns from the df once they are assigned to new columns as they are not being used further anyway?
response = { | ||
'startDate': start_date.__str__(), | ||
'endDate': end_date.__str__(), | ||
'results': results.to_dict('records') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only this field seems to be differing in this if-else
block.
@@ -27,6 +29,12 @@ def __init__(self,configpath="",index=""): | |||
verify_certs=False, | |||
http_auth=(self.esUser,self.esPass) | |||
) | |||
self.sync_es = Elasticsearch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need resolving some conflicts here.
thanks @vishnuchalla for having a loook, |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 6 days with no activity. |
Type of change
Description
This PR adds PSAP RHOAI Notebooks Performance tests to the HOME page of the CPT Dashboard
Note that this PR includes multiple WIP commits. These commits will not be included in the final version of the PR.
Related Tickets & Documents
Checklist before requesting a review
Testing