Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add RHOAI Notebooks Performance tests to the HOME page #84

Closed
wants to merge 13 commits into from

Conversation

kpouget
Copy link
Contributor

@kpouget kpouget commented Jan 29, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

This PR adds PSAP RHOAI Notebooks Performance tests to the HOME page of the CPT Dashboard

Note that this PR includes multiple WIP commits. These commits will not be included in the final version of the PR.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@jtaleric jtaleric requested review from chentex and athiruma January 31, 2024 13:25
Copy link

github-actions bot commented Mar 1, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 1, 2024
Copy link

github-actions bot commented Mar 7, 2024

This PR was closed because it has been stalled for 6 days with no activity.

@github-actions github-actions bot closed this Mar 7, 2024
@jtaleric jtaleric reopened this Mar 7, 2024
@jtaleric
Copy link
Member

jtaleric commented Mar 7, 2024

Bad bot.

@jtaleric jtaleric added enhancement New feature or request and removed Stale labels Mar 7, 2024
@jtaleric
Copy link
Member

jtaleric commented Mar 7, 2024

@kpouget is this still being worked on?

@kpouget
Copy link
Contributor Author

kpouget commented Mar 7, 2024

it's on hold, too many things to do, too few persons!
But the idea is still open, we'll get to it, sooner or later :)

if df.empty:
return df

df["startDate"] = df["metadata.start"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove these metadata.* columns from the df once they are assigned to new columns as they are not being used further anyway?

response = {
'startDate': start_date.__str__(),
'endDate': end_date.__str__(),
'results': results.to_dict('records')
Copy link
Collaborator

@vishnuchalla vishnuchalla Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this field seems to be differing in this if-else block.

@@ -27,6 +29,12 @@ def __init__(self,configpath="",index=""):
verify_certs=False,
http_auth=(self.esUser,self.esPass)
)
self.sync_es = Elasticsearch(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need resolving some conflicts here.

@kpouget
Copy link
Contributor Author

kpouget commented Mar 14, 2024

thanks @vishnuchalla for having a loook,
this work is currently on hold because of lack of time, but we'll get back to it :)

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Apr 13, 2024
Copy link

This PR was closed because it has been stalled for 6 days with no activity.

@github-actions github-actions bot closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants