Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic to use internal ES instance #86

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Feb 14, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Logic to use ES internal instance for data older than 7 days and use new instance only for last 1 week's data. Also optimizes query logic to only scan indexes within given time range instead of the entire index patterns.
Related JIRA for more context: https://issues.redhat.com/browse/PERFSCALE-2831

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • These changes are bringing up the UI in local using sh local-compose.sh. Please feel free to reach-out offline for test credentials.
  • Verified data for all the UI tabs and kube-burner, k8s-netperf and ingress-perf results.

Copy link
Member

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed and tested the PR and everything is working as expected, apart from the comments made by Raul and Joe, I have nothing else to add.

Signed-off-by: Vishnu Challa <[email protected]>
Copy link
Member

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtaleric jtaleric merged commit 3e4bf3c into cloud-bulldozer:main Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants