Combine metric profiles #438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
requested review from
afcollins,
dry923,
Harshith-umesh and
mohit-sheth
|
/rerun all |
|
Results for e2e-benchmarking CI Tests
|
|
/rerun all WORKLOAD=node-density ./run.sh |
|
Results for e2e-benchmarking CI Tests
|
|
/rerun all kube-burner:WORKLOAD=node-density ./run.sh |
|
Results for e2e-benchmarking CI Tests
|
|
@rsevilla87 thoughts on reviewing and updating this PR's logic #411 here? or closing it if it's no longer relevant? |
afcollins
approved these changes
Jul 13, 2022
|
/rerun all kube-burner:WORKLOAD=node-density ./run.sh |
|
Results for e2e-benchmarking CI Tests
|
|
Let's put this one on hold, I have to make some change in the grafana report to ensure we don't loss any interesting metric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combine metrics-aggregated.yaml and metrics.yaml files.
I managed to combine them thanks to expressions such as:
Which uses the magic variable {{ .elapsed }} which takes the value of the benchmark duration. Now, in large-scale deployments we won't collect metrics for all worker nodes (which is overkill) but instead we'll collect metrics for the 3 worker nodes with more kubelet CPU usage, same for other similar metrics.