-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added container-based VM tests #541
base: master
Are you sure you want to change the base?
Conversation
run.sh - added the node-vm-density case added folder node-vm-density - VM template and settings
added node-vm-density description
Can one of the admins verify this patch? |
disks: | ||
- disk: | ||
bus: virtio | ||
name: node-vm-density |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ - disk:
+ bus: virtio
+ name: cloudinitdisk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, why?
some 1 might want to add more disks, and I like the name convention it fits the role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the cloudInitNoCloud section to set pw / config ssh so this template would fail w/out defining the corresponding disk
(error was: spec.template.spec.domain.volumes[1].name 'cloudinitdisk' not found
)
Could we add a check to the |
Checking @bbenshab if this is still relevant? |
Checking in again |
Description
added container-based VM tests + updated README.md
Fixes