Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s metadata #37

Closed
wants to merge 2 commits into from
Closed

K8s metadata #37

wants to merge 2 commits into from

Conversation

rsevilla87
Copy link
Member

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Some updates required to make this library compatible with vanilla k8s

  • Adding new GetK8SMetadata() function to get only an small subset of metadata
  • Omitting empty metadata fields
  • Count control-plane nodes as masters

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Copy link

Code coverage: 86.8%%

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc2da49) 83.33% compared to head (d9a5afb) 83.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           6        6           
  Lines         312      312           
=======================================
  Hits          260      260           
  Misses         38       38           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsevilla87 rsevilla87 closed this Nov 21, 2023
@rsevilla87 rsevilla87 deleted the k8s-metadata branch November 21, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant