Update verify connection API call #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 84.79% 84.66% -0.14%
==========================================
Files 6 6
Lines 342 339 -3
==========================================
- Hits 290 287 -3
Misses 38 38
Partials 14 14 ☔ View full report in Codecov by Sentry. |
mukrishn
reviewed
Feb 21, 2024
| return err | ||
| } | ||
| return nil | ||
| _, err := p.Query("up{}", time.Now().UTC().UTC()) |
There was a problem hiding this comment.
Yes this works, but on a large scale cluster it returns a bulk of data as it checks all target endpoints, hope that is fine.
5 tasks
vishnuchalla
pushed a commit
to kube-burner/kube-burner
that referenced
this pull request
Feb 21, 2024
## Type of change - [ ] Refactor - [ ] New feature - [ ] Bug fix - [x] Optimization - [ ] Documentation Update ## Description Includes fix cloud-bulldozer/go-commons#42 cc: @mukrishn ## Related Tickets & Documents - Related Issue # - Closes # Signed-off-by: Raul Sevilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The previous API call doesn't work in AKS's prometheus instances. Seems like endpoints from the /status path are not exposed
Related Tickets & Documents
Checklist before requesting a review