Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERFSCALE-3398] Ocp virt version #51

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

rsevilla87
Copy link
Member

Type of change

  • Optimization

Description

From the different alternatives to get the version I've tested, I think this one is the more reliable and simple.

Using the csv could work, but the name of the csv is not consistent, and changes with the deployed version, which makes the logic more complex:

 $ oc get csv -n openshift-cnv
NAME                                       DISPLAY                    VERSION   REPLACES                                   PHASE
kubevirt-hyperconverged-operator.v4.17.1   OpenShift Virtualization   4.17.1    kubevirt-hyperconverged-operator.v4.17.0   Succeeded

Something similar with the installplan

$ oc get installplan -A
NAMESPACE       NAME            CSV                                        APPROVAL    APPROVED
openshift-cnv   install-rhjt5   kubevirt-hyperconverged-operator.v4.17.1   Automatic   true

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (7b66b75) to head (ac5a635).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   82.23%   82.23%           
=======================================
  Files           6        6           
  Lines         349      349           
=======================================
  Hits          287      287           
  Misses         48       48           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Raul Sevilla <[email protected]>
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jtaleric jtaleric merged commit 196895f into cloud-bulldozer:main Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants